chore(e2e): bump protractor to 4.0.5#2054
Merged
hansl merged 1 commit intoangular:masterfrom Sep 12, 2016
Merged
Conversation
cexbrayat
force-pushed
the
fix/1977-protractor
branch
from
3e96775 to
ad062ba
Compare
Contributor
|
Wow, okay. |
Contributor
|
LGTM. Thanks! |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Sep 12, 2016
Followup from angular#2054 Now our files depend on the node typings, so we should have it as an explicit dependency.
hansl
pushed a commit
that referenced
this pull request
Sep 12, 2016
Followup from #2054 Now our files depend on the node typings, so we should have it as an explicit dependency.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1977
Protractor 4.0.3 has a critical bug, and will return a success code even if the tests are failing or if there is no
ng serverunning... (see the related angular/protractor#3505)4.0.5 fixes it, but it now relies on
@types/node(as stated in the changelog https://github.com/angular/protractor/blob/master/CHANGELOG.md#405), which conflicts with the declarations in thetypings.d.tsfile. As they are now duplicated, removing them from thetypings.d.tsfile solves the problem.declare var require: any;has to be added to thetest.tsfile because this is not the sameNodeRequirethat@types/nodedeclares, but aWebpackRequirewith thecontextfield.There is probably a more elegant solution to solve this, but at least this one unblocked us.